Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Document.requestStorageAccessFor() #21292

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add Document.requestStorageAccessFor() #21292

merged 2 commits into from
Nov 22, 2023

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 21, 2023

The collector found this new method on Document.
I was unable to confirm version 118 on Chromestatus. There is no entry.
Maybe @chrisdavidmills knows more otherwise I would trust the collector and go with 118 here.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 21, 2023
@chrisdavidmills
Copy link
Contributor

There's an entry here: https://chromestatus.com/feature/5122534152863744. That says supported in 115.

requestStorageAccessFor() is closely related to Related Website Sets, which used to be called First Party Sets. See https://chromestatus.com/feature/5640066519007232. That also says supported in 115.

I intend to document both of these on MDN pretty soon. I can ask about the support if you like.

@chrisdavidmills chrisdavidmills changed the title Add Document.requestRequestStorageFor Add Document.requestStorageAccessFor() Nov 21, 2023
@chrisdavidmills
Copy link
Contributor

@Elchi3 I got some feedback from Chrome engineering about this:

"RWS did end up being released later than M115 - it was finally enabled for all clients in M119, please update the compat data accordingly."

Elchi3
Elchi3 commented Nov 22, 2023
View reviewed changes
api/Document.json Outdated Show resolved Hide resolved
chrisdavidmills
chrisdavidmills approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Elchi3 Elchi3 merged commit 96b86b8 into mdn:main Nov 22, 2023
4 checks passed
@Elchi3 Elchi3 deleted the rsaFor branch November 22, 2023 15:22
@tunetheweb tunetheweb mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @chrisdavidmills