Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat data for import attributes #20949

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Conversation

nicolo-ribaudo
Copy link
Contributor

Summary

This PR adds compat data for the Stage 3 "import attributes" proposal (https://tc39.es/proposal-import-attributes/).

MDN already has data for the old version of the proposal: I left it there and marked it as deprecated, as the proposal does (https://tc39.es/proposal-import-attributes/#sec-deprecated-assert-keyword-for-import-attributes)

Test results and supporting details

https://deno.com/blog/v1.37

Related issues

mdn/content#29572

@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Oct 12, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Two questions for you

javascript/statements.json Show resolved Hide resolved
javascript/statements.json Outdated Show resolved Hide resolved
javascript/statements.json Show resolved Hide resolved
javascript/statements.json Outdated Show resolved Hide resolved
javascript/statements.json Outdated Show resolved Hide resolved
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nicolo-ribaudo 👍

@Elchi3 Elchi3 merged commit f20cf56 into mdn:main Nov 13, 2023
4 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the import-attributes branch November 13, 2023 15:03
@nicolo-ribaudo
Copy link
Contributor Author

Thanks for finishing this!

Elchi3 added a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* Compat data for import attributes

* `npm run fix`

* Apply suggestions from code review

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>

* Node.js 21.0.0 supports it

* update id

---------

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants