Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Node support for EventTarget #20889

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Updated Node support for EventTarget #20889

merged 1 commit into from
Oct 3, 2023

Conversation

Cipscis
Copy link
Contributor

@Cipscis Cipscis commented Oct 3, 2023

Summary

The compatability data says Node doesn't support the signal property of EventTarget.addEventListener. However, this support was added in node v15.4.0.

Test results and supporting details

Node Changelog
Node PR merge comment

Related issues

Fixes #18883

`addEventListener` has `signal` option support since Node 15.4.0
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 3, 2023
@gamliela
Copy link

gamliela commented Oct 3, 2023

Nice, thanks!

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the PR number does not show up in the v14 changelog. LGTM, thank you for your PR! And welcome to BCD! 🎉

@queengooborg queengooborg merged commit 48737d7 into mdn:main Oct 3, 2023
3 checks passed
Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
`addEventListener` has `signal` option support since Node 15.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api.EventTarget.addEventListener - options.signal is supported on node.js
3 participants