css: "start", "end" values in flex context #12602
Conversation
with values start, end are not supported
github-actions
bot
added
the
data:css
|
The support data for some of the other Chromium based browsers is incorrect too. Specifically Opera, Opera Android and Samsung Internet. |
ZerdoX-x
changed the title
|
Thank you. So this should be ok now. Feel free to report info if you'll find more issues with this. |
|
Let me know if something holding back from reviewing & merging |
|
Thank you so much. I've tested it in opera mobile by myself now. And I am not sure that support of this values in Opera has been added exactly in 79. Maybe a bit earlier? |
|
Opera 79 correlates to Chrome 93 which is what the existing support data says so I'm assuming it's correct. Not sure if the notes should be kept for the version_added false entries (Samsung and Opera Android) but one of the maintainers will let you know if that's an issue when they review. |
|
There were some notes in some files but I guess this data shouldn't differ across css properties as this is one feature so I removed that notes already. |
|
So can someone review this too please? |
There was a problem hiding this comment.
Hi @ZerdoX-x and thanks for this PR. I see it's your first to the project—welcome! I do think we need to do something about the old notes. I've left a line comment to try to explain. Let me know if there are any questions. Thanks again!
|
@ddbeck here you are |
Summary
Removing wrong & adding support data: "start" and "end" values in flex context (align-self, align-items, align-content, justify-content)
Updated browsers:
Safari, safari mobile, opera mobile, samsung internet – Incorrect support data removed
Opera 79 – Support data added
Test results and supporting details
Tested by me on Linux in WebKitGTK 2.32.4 and my friends on OSX and IOS (different safari versions)
Tested in Opera 79.0.4143.50
Tested in Opera Mobile 65.1.3381.61266
Tested in Samsung Internet 15
align-self: end;demo: https://codepen.io/zerdox-x/pen/rNwQXRealign-items: end;demo: https://codepen.io/zerdox-x/pen/MWoxXdKalign-content: end;demo: https://codepen.io/zerdox-x/pen/powYZojjustify-content: end;demo: https://codepen.io/zerdox-x/pen/JjJeVyR