-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM all the things #12161
Merged
Merged
ESM all the things #12161
Changes from 18 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1c63552
ESM all the things
lucacasonato 9bc2ce2
Merge branch 'main' into esm_all_the_things
queengooborg 4074a80
Fix formatting
queengooborg d7aeb66
Add missing import
queengooborg 9ffd02f
Fix remaining files
queengooborg 4b957ee
Install es-main package
queengooborg f4c1bc0
Utilize es-main package
queengooborg ba8ff3c
Import yargs hideBin() helper
queengooborg 32708b2
Fix exports
queengooborg d1ff939
Wrap yargs/executable script parts within esMain
queengooborg 3e29fe6
Fix yargs
queengooborg 3d33917
Fix imports
queengooborg 2fee2f2
Move main function down in diff-features
queengooborg 7f3b30b
Fix exports for diff-features
queengooborg dd208db
Fix release-notes script
queengooborg 1de266c
Fix enumerate-features
queengooborg 3b94eaa
Merge branch 'main' into esm_all_the_things
queengooborg ba01cda
review comments
lucacasonato 7fd90a3
Merge branch 'main' into esm_all_the_things
queengooborg 3bd064d
Fix imports and exports
queengooborg a00de8a
Fix imports/exports, cleanup code, cleanup diff, fix scripts
queengooborg f4db6ed
Fix import
queengooborg 9be1335
Use import assertion for browser-specs (we're using NodeJS v16)
queengooborg 35f0457
Fix ESLint
queengooborg 6acf25a
Merge branch 'main' into esm_all_the_things
queengooborg c6c687c
Fix unittest
queengooborg 66d49fa
Fix unittest (again)
queengooborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,6 @@ | ||
/* Any copyright is dedicated to the Public Domain. | ||
* http://creativecommons.org/publicdomain/zero/1.0/ */ | ||
/// <reference path="./types.d.ts"/> | ||
|
||
import { CompatData } from './types'; | ||
|
||
// This is necessary to have intellisense in projects which | ||
// import data from this package. | ||
declare const compatData: CompatData; | ||
export = compatData; | ||
export default CompatData; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert this change, since BCD isn't ESM-ready yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, this change would have to wait until the first ESM-compatible version of BCD is released, right?
PS: I guess that will be a major version bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, see #15775 for the ESM-ready public builds!