Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant api.HTMLMediaElement.onmozinterrupt feature #12094

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR removes the irrelevant onmozinterrupt member of the HTMLMediaElement API as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v3.2.9), even if the current BCD suggests support.

This PR removes the irrelevant `onmozinterrupt` member of the `HTMLMediaElement` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.9), even if the current BCD suggests support.
@queengooborg queengooborg added needs-release-note 📰 needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Aug 21, 2021
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 21, 2021
@queengooborg queengooborg added needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation and removed needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Aug 21, 2021
@queengooborg
Copy link
Collaborator Author

Looks like the MDN content has already been removed!

@ddbeck ddbeck added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Sep 6, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 6, 2021

Looks like the MDN content has already been removed!

Not quite, unfortunately. Looks like there's still an "Obsolete event handlers section" on that page (unless there's a PR I've missed).

@queengooborg
Copy link
Collaborator Author

queengooborg commented Sep 7, 2021

Not quite, unfortunately. Looks like there's still an "Obsolete event handlers section" on that page (unless there's a PR I've missed).

Ack, good catch, I hadn't looked for other references, just the linked pages... 😅 Content PR incoming submitted and has now been merged!

@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Sep 7, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🎉

@ddbeck ddbeck merged commit 07c32af into mdn:main Oct 3, 2021
@queengooborg queengooborg deleted the api/HTMLMediaElement/onmozinterrupt/removal branch October 3, 2021 22:22
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 12, 2021

@queengooborg While writing the release note for this, I noticed this actually adds a new feature called onerror. Was that intentional?

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 12, 2021
@queengooborg
Copy link
Collaborator Author

Eek, adding a feature was definitely not intentional in this PR... I'll send a PR to remove it since the feature is covered by the GlobalEventHandlers mixin!

ddbeck added a commit that referenced this pull request Oct 12, 2021
* Bump version to v4.0.6

* Add release note for #12094

* Add release note for #12367

* Add release note for #12462

* Add release note for #12490

* Add release note for #12565

* Add release note for #12632

* Add release note for #12638

* Add release note for #12639

* Add release note for #12703

* Add release note for #12718

* Add release note for #12723

* Add release note for #12768

* Add release note for #12770

* Add release note for #12772

* Add release note for #12794

* Add release note for #12796

* Add release note for #12813

* Add stats and hoist known issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants