Add XRPose.{angular,linear}Velocity #11813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
|
Blocked by #12642 which will introduce Oculus and then these features won't be all false anymore. |
queengooborg
added
the
not ready ⛔
queengooborg
removed
the
not ready ⛔
|
#12642 was closed due to a lack of maintenance, so I think we might as well merge this while we await a new PR to add Oculus data? |
|
If we merge, then these would be all-false features... Maybe we should close this PR instead? |
|
That's true... I'm down to close this PR then if you are! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all-false features (#10619)
but
Are these valid enough points to add the features anyways?