Adding Temporal API #10643
Adding Temporal API #10643
Conversation
github-actions
bot
added
the
data:js 📟
https://github.com/mdn/browser-compat-data/blob/master/schemas/compat-data.schema.json#L255-L264 doesn’t allow feature identifiers to contain parenthesis; instead it restricts them to "^(?!__compat)[a-zA-Z_0-9-$@]*$". And in the rest of the tree, existing feature identifiers method names omit the parenthesis.
The spec_url value isn’t allowed to be empty — so if there’s no spec URL (yet), the spec_url key/value should be omitted completely.
spec_url values must contain a fragment ID.
I think this change also replaces tabs with spaces, and adds newlines to the ends of the files.
|
This is currently blocked by #10619, where we're deciding whether or not to allow for all-false features within BCD. As such, I'll be marking this as "not ready" for the time being. |
queengooborg
added
the
not ready ⛔
Fair enough. Thanks for the update! |
|
Temporal support is landing in Safari Technology Preview as of STP 133, so this is no longer all-false! If there’s a way to get this back on the “review and merge” train, let’s do it. |
|
@queengooborg Could you remove the “Not ready” tag from this one, please? I’d do it myself but I don’t have the permissions. |
queengooborg
removed
the
not ready ⛔
|
@meyerweb To get this moving again, we'd need to have the supported Safari features set to |
I do. Remind me again, is there anything I need to say other than |
|
If it's enabled by default in Safari TP releases, then |
|
Updated the information to what my testing shows (using https://people.igalia.com/emeyer/js/tests/). |
|
Thanks for the quick updates! Last thing: I noticed that there are a number of added features marked as all-false. We should probably remove them until a decision has been made of whether to keep them or not, but I'll defer to @ddbeck on that one. |
Yes, portions of the Temporal API have yet to be implemented. My feeling is that if we have parts of the API, then we should have all of it, even if it’s all-false. That way readers get a clear view of what’s been done, and what hasn’t, instead of seeing that parts are available for testing out but not having any insight into the status of the rest of the API. But that’s my personal take and may run afoul of the current state of MDN policy. |
There was a problem hiding this comment.
Thank you for waiting, and thank you for your hard work on this PR! Although we're still deciding whether we want to keep/introduce all-false features in BCD, the general consensus is currently to disallow features without a valid spec URL. You make a great point, in that if we're adding part of the API, we should add all of it.
This PR is looking good to me, thank you!
|
Thank you! |
Summary
Addition of the Temporal API to BCD.