Parse BSS Load Information Elements #64

lukas-mbag · 2023-12-01T14:33:21Z

This change extends the parsing of the Information Elements to include the QBSS-Load Element

BSS-Load parameters are included in a custom struct (with proper String() Method)
Supports both Versions (same as Wireshark) - See func decodeBSSLoad(b []byte) (*BSSLoad, error)
Includes the Following Parameters of the QBSS-Load:
- Station Count
- Channel Utilization
- Available Admission Capacity

Additionally the output of a failed test in TestIntegrationLinuxConcurrent has been extended.

The program was tested solely for our own use cases, which might differ from yours.
Especially I only tested in WLAN-Networks with QBBS Load Version 2 (Wireshark calls this "802.11e CCA Version").

Lukas Raffelt < lukas.raffelt@mercedes-benz.com > on behalf of Mercedes-Benz Tech Innovation GmbH, Provider Information

Licensed under MIT

lukas-mbag · 2023-12-08T08:18:43Z

Hey @SuperQ and @mdlayher ,
did you have any chance to look at this merge-request?
Since this is my first contribution to this project, is there anything I am missing or can improve?

Or am I just too impatient? ;)

Cheers Lukas

SuperQ · 2023-12-10T13:51:17Z

One nice thing to do would be to squash your commits into logical changes. Rather than have a bunch of "Fix typo" changes.

lukas-mbag · 2023-12-11T10:30:21Z

Shall I do this right now (and invalidate the checks and so ...)? Or more as a general advice for my next pull request?

SuperQ · 2023-12-11T10:41:44Z

Yes, you can rebase/sqaush/change whenever you feel like.

SuperQ

Minor nits, but otherwise LGTM.

wifi.go

SuperQ · 2023-12-11T10:53:34Z

client_linux.go

@@ -544,3 +551,26 @@ func decodeSSID(b []byte) string {

 	return buf.String()
 }
+
+// decodeBSSLoad Decodes the BSSLoad IE. Supports Version 1 and Version 2
+// values according to https://raw.githubusercontent.com/wireshark/wireshark/master/epan/dissectors/packet-ieee80211.c


Is there any documentation other than wireshark source code for these formats? Linking to a > 2MiB source file isn't my preference.

Implementation in iw scan command is comparable in size.

See Line 1640ff in scan.c and Line 1826

But I will do another search for better references.

Edit: Links that do not point to a rolling master branch but to a fixed release Line 1634ff in scan.c of release v5.19

I also checked the IEEE Std 802.11-2020 as a primary source. That document is approx 4000 pages long, The relevant definition of the BSS Load Information Element can be found in chapter 9.4.2.27.

I will add the reference to the primary source and change the descriptions to closer match the language in the primary source to reduce any confusion.

What do you think about that solution?

client_linux_integration_test.go

lukas-mbag · 2023-12-11T12:25:00Z

Thanks for the input.

I will work on the suggestions later today and squash the commits to more sensible commits.

make following IE Parameters availiable: * StationCount * ChannelUtilization * AvailableAdmissionCapacity Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> more docs for BSS Load elements Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> more docs for BSS Load elements Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> add Parsing Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> restructure to sub-Element Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> skip malformed IE if decodeBSSLoad returns error Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> reset integration test to default parameters Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

Co-authored-by: Ben Kochie <superq@gmail.com> fix typo Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> expand documentation Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

Includes references to the IEEE 802.11 Chapter that defines the Information Element Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

lukas-mbag · 2024-02-07T14:21:14Z

rebased on the current master.

Anything missing for a successful merge?

lukas-mbag · 2024-05-16T11:23:33Z

Hey @SuperQ any chance for the merge request to do through soon? Or do we still wait for the review from @mdlayher?

mdlayher · 2024-05-16T16:08:23Z

I'll leave it up to @SuperQ, I have not been actively participating in this library for some time.

SuperQ

Some minor nits.

client_linux.go

wifi.go

Co-authored-by: Ben Kochie <superq@gmail.com>

lukas-mbag · 2024-05-21T08:50:58Z

Applied all suggestions, thanks for the feedback!

SuperQ

Can you fix the other issues similar to my suggestions? There are other Go doc issues.

lukas-mbag · 2024-05-21T09:05:21Z

ah, sorry I thought everything was in the suggestions, will do it now

formated Godocs of types BSS and BSSLoad Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

lukas-mbag · 2024-05-21T09:51:20Z

I have formatted the go Doc comments in my new Type BSSLoad similar to the suggested changes. I also harmonized the doc strings in type BSS.

SuperQ

Awesome, thanks! Fixing the doc strings helps a bunch.

lukas-mbag marked this pull request as ready for review December 1, 2023 14:34

SuperQ requested a review from mdlayher December 10, 2023 13:50

SuperQ approved these changes Dec 11, 2023

View reviewed changes

lukas-mbag force-pushed the feat-QBSSLoad-IEs branch 2 times, most recently from c7633dd to 4ac0888 Compare December 11, 2023 17:29

lukas-mbag changed the title ~~Parse QBSS Load Information Elements~~ Parse BSS Load Information Elements Feb 7, 2024

lukas-mbag and others added 6 commits February 7, 2024 15:05

improve Output of integration test

5942b77

Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

add test cases

57924f1

Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> reset integration test to default parameters Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

suggested doc changes

47ea31c

Co-authored-by: Ben Kochie <superq@gmail.com> fix typo Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com> expand documentation Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

extend documentation with primary source

a501f94

Includes references to the IEEE 802.11 Chapter that defines the Information Element Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

lukas-mbag force-pushed the feat-QBSSLoad-IEs branch from 40d9f30 to a501f94 Compare February 7, 2024 14:06

SuperQ requested changes May 16, 2024

View reviewed changes

client_linux.go Outdated Show resolved Hide resolved

wifi.go Outdated Show resolved Hide resolved

wifi.go Outdated Show resolved Hide resolved

Apply suggestions from code review

24f3dd0

Co-authored-by: Ben Kochie <superq@gmail.com>

lukas-mbag requested a review from SuperQ May 21, 2024 08:52

SuperQ requested changes May 21, 2024

View reviewed changes

improve goDoc

508c95c

formated Godocs of types BSS and BSSLoad Signed-off-by: Lukas Raffelt <lukas.raffelt@mercedes-benz.com>

SuperQ approved these changes May 21, 2024

View reviewed changes

SuperQ merged commit e031f90 into mdlayher:main May 21, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse BSS Load Information Elements #64

Parse BSS Load Information Elements #64

lukas-mbag commented Dec 1, 2023 •

edited

Loading

lukas-mbag commented Dec 8, 2023

SuperQ commented Dec 10, 2023

lukas-mbag commented Dec 11, 2023

SuperQ commented Dec 11, 2023

SuperQ left a comment

SuperQ Dec 11, 2023

lukas-mbag Dec 11, 2023 •

edited

Loading

lukas-mbag Feb 7, 2024 •

edited

Loading

SuperQ May 16, 2024

lukas-mbag commented Dec 11, 2023

lukas-mbag commented Feb 7, 2024

lukas-mbag commented May 16, 2024 •

edited

Loading

mdlayher commented May 16, 2024

SuperQ left a comment

lukas-mbag commented May 21, 2024

SuperQ left a comment

lukas-mbag commented May 21, 2024 •

edited

Loading

lukas-mbag commented May 21, 2024

SuperQ left a comment

Parse BSS Load Information Elements #64

Parse BSS Load Information Elements #64

Conversation

lukas-mbag commented Dec 1, 2023 • edited Loading

lukas-mbag commented Dec 8, 2023

SuperQ commented Dec 10, 2023

lukas-mbag commented Dec 11, 2023

SuperQ commented Dec 11, 2023

SuperQ left a comment

Choose a reason for hiding this comment

SuperQ Dec 11, 2023

Choose a reason for hiding this comment

lukas-mbag Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

lukas-mbag Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

SuperQ May 16, 2024

Choose a reason for hiding this comment

lukas-mbag commented Dec 11, 2023

lukas-mbag commented Feb 7, 2024

lukas-mbag commented May 16, 2024 • edited Loading

mdlayher commented May 16, 2024

SuperQ left a comment

Choose a reason for hiding this comment

lukas-mbag commented May 21, 2024

SuperQ left a comment

Choose a reason for hiding this comment

lukas-mbag commented May 21, 2024 • edited Loading

lukas-mbag commented May 21, 2024

SuperQ left a comment

Choose a reason for hiding this comment

lukas-mbag commented Dec 1, 2023 •

edited

Loading

lukas-mbag Dec 11, 2023 •

edited

Loading

lukas-mbag Feb 7, 2024 •

edited

Loading

lukas-mbag commented May 16, 2024 •

edited

Loading

lukas-mbag commented May 21, 2024 •

edited

Loading