Refactor collection serializer

Define write_fields next to read_fields. [noissue]
mdellweg · Nov 21, 2024 · 94f9386 · 94f9386
1 parent a946077
commit 94f9386
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/pulp_ansible/app/serializers.py b/pulp_ansible/app/serializers.py
@@ -689,17 +689,12 @@ def is_valid(self, raise_exception=False):
         See Validating Models:
             https://docs.pulpproject.org/pulpcore/plugins/plugin-writer/concepts/index.html
         """
-        write_fields = set(CollectionVersionUploadSerializer.Meta.fields) - {
-            "pulp_created",
-            "pulp_last_updated",
-            "sha256",
-        }
         if hasattr(self, "initial_data"):
             if any((x in self.initial_data for x in self.Meta.read_fields)):
                 # Pop shared fields: artifact & repository
                 artifact = self.initial_data.pop("artifact", None)
                 repository = self.initial_data.pop("repository", None)
-                if any((x in self.initial_data for x in write_fields)):
+                if any((x in self.initial_data for x in self.Meta.write_fields)):
                     if raise_exception:
                         raise ValidationError(
                             _("Read and write fields can not be used at the same time")
@@ -744,6 +739,11 @@ class Meta:
             + ContentChecksumSerializer.Meta.fields
             + read_fields
         )
+        write_fields = set(CollectionVersionUploadSerializer.Meta.fields) - {
+            "pulp_created",
+            "pulp_last_updated",
+            "sha256",
+        }
         model = CollectionVersion