Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge GetBlobsBundleV1 with GetPayloadV3 per spec update #121

Merged
merged 1 commit into from
Apr 21, 2023
Merged

merge GetBlobsBundleV1 with GetPayloadV3 per spec update #121

merged 1 commit into from
Apr 21, 2023

Conversation

roberto-bayardo
Copy link
Collaborator

@roberto-bayardo roberto-bayardo requested a review from Inphi April 21, 2023 15:20
@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch 3 times, most recently from a3276b1 to ffbcffe Compare April 21, 2023 15:35
Inphi
Inphi approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. We should also remove the get blobs bundle API from capabilities

Inphi
Inphi requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i just realized. The execution payload codegen needs to be updated

@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch from ffbcffe to 750365d Compare April 21, 2023 20:14
@roberto-bayardo roberto-bayardo force-pushed the merge-getblob-getpayload branch from 750365d to 7270ef8 Compare April 21, 2023 20:16
@roberto-bayardo
Copy link
Collaborator Author

looks good. We should also remove the get blobs bundle API from capabilities

done!

oh i just realized. The execution payload codegen needs to be updated

right, I knew I was forgetting something. done!

@roberto-bayardo roberto-bayardo requested a review from Inphi April 21, 2023 20:17
Inphi
Inphi approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
small nit: we can now get both the blobs bundle and payload from the cache as a single operation. This avoids a small chance of inconsistency if the raw payload was evicted immediately after we retrieved the block but before we attempted to read the blobs bundle.

@roberto-bayardo
Copy link
Collaborator Author

Looks good. small nit: we can now get both the blobs bundle and payload from the cache as a single operation. This avoids a small chance of inconsistency if the raw payload was evicted immediately after we retrieved the block but before we attempted to read the blobs bundle.

right, let me fix that in the next PR where I'll also implement the proofs inclusion.

@roberto-bayardo roberto-bayardo merged commit 15504a6 into eip-4844 Apr 21, 2023
@roberto-bayardo roberto-bayardo deleted the merge-getblob-getpayload branch April 21, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inphi Inphi Inphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberto-bayardo @Inphi