Apply suggestions from code review

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
mdboom · Jul 30, 2024 · d6c54ee · d6c54ee
1 parent 398988d
commit d6c54ee
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/Include/internal/pycore_magic_number.h b/Include/internal/pycore_magic_number.h
@@ -268,7 +268,10 @@ PC/launcher.c must also be updated.
 */
 
 #define PYC_MAGIC_NUMBER 3603
-#define PYC_MAGIC_NUMBER_TOKEN ((uint32_t)PYC_MAGIC_NUMBER | ((uint32_t)'\r' << 16) | ((uint32_t)'\n' << 24))
+/* This is equivalent to converting PYC_MAGIC_NUMBER to 2 bytes
+   (little-endian) and then appending b'\r\n'. */
+#define PYC_MAGIC_NUMBER_TOKEN \
+    ((uint32_t)PYC_MAGIC_NUMBER | ((uint32_t)'\r' << 16) | ((uint32_t)'\n' << 24))
 
 
 #ifdef __cplusplus

diff --git a/Lib/test/test_import/__init__.py b/Lib/test/test_import/__init__.py
@@ -3119,7 +3119,7 @@ def test_magic_number_endianness(self):
         magic_number = (_imp.pyc_magic_number).to_bytes(2, 'little') + b'\r\n'
         raw_magic_number = int.from_bytes(magic_number, 'little')
 
-        assert raw_magic_number == _imp.pyc_magic_number_token
+        self.assertEqual(raw_magic_number, _imp._pyc_magic_number_token)
 
 
 if __name__ == '__main__':

diff --git a/Python/import.c b/Python/import.c
@@ -4814,7 +4814,9 @@ imp_module_exec(PyObject *module)
         return -1;
     }
 
-    if (PyModule_AddIntConstant(module, "pyc_magic_number_token", PYC_MAGIC_NUMBER_TOKEN) < 0) {
+    if (PyModule_AddIntConstant(
+            module, "pyc_magic_number_token", PYC_MAGIC_NUMBER_TOKEN) < 0)
+    {
         return -1;
     }