Fix GNU syslog #63
Merged
Fix GNU syslog #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't seem to work with GNU syslog()
I have especially tested its integration with
systemd-journald, and I'm not getting messages from/run/systemd/journal/syslogcorrectly.The error appears to be in the fact that GNU syslog() (and therefore, journald) omits the hostname from their messages.
My patch understands this case, and assumes it is a local message in that case.
I also added unit tests to ensure that both "normal" 3164 messages and GNU variant is working correctly.