Add bounds checks to rfc5424 parser #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We're streaming logs via syslog from our CDN provider, and sometimes the server crashes with "out of range panic":
It could be caused by our network, not CDN, but in any case we would like to prevent crashing and gracefully error out.
I fixed the panic mentioned above with an explicit test
TestParseTimestamp_Empty
. Then I added a test that feeds truncated messages to the panic and prevented corresponding panics.Please let me know if anything needs to be changed.