Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: use sample interval default 1000 #436

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

RafaelGSS
Copy link
Contributor

This PR is causing unexpected behavior in some measurements:

fastify/benchmarks#233 and I believe for most of the users is better to use default as 1000 at least is more readable than:

│ Stat      │ 1%      │ 2.5%    │ 50%     │ 97.5%   │ Avg     │ Stdev   │ Min   │
├───────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼───────┤
│ Req/Sec   │ 16      │ 32      │ 55      │ 89      │ 54.75   │ 11.09   │ 1     │
├───────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼───────┤
│ Bytes/Sec │ 2.99 kB │ 5.99 kB │ 10.3 kB │ 16.7 kB │ 10.2 kB │ 2.07 kB │ 187 B │
└───────────┴─────────┴─────────┴─────────┴─────────┴─────────┴─────────┴───────┘

Req/Bytes counts sampled every 0.001 seconds.

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS
Copy link
Contributor Author

@mcollina can you re-run all jobs, please? I don't have this permission

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants