fixed issue where latency table was never rendered #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -i/--input FILE The body of the request. default: `undefined`. | ||
| -H/--headers K=V The request headers. default: `undefined`. | ||
| -B/--bailout NUM The number of failures before initiating a bailout. default: `undefined`. | ||
| -p/--progress Display the progress bar. default: `true`. |
There was a problem hiding this comment.
I don't think we need this switch. It would be --no-progress in case, but why would this be needed? If it's not a TTY it's omitted anyway.
There was a problem hiding this comment.
After the fiasco with the npm progress bar, some people might like this option? I just thought it might be nice to give users the option. Also, I chose --progress over --no-progress to match npm, as well.
There was a problem hiding this comment.
Then we should document --no-progress
|
Also, it conflicts with #25 :(. Can you please update this one so that it applies cleanly? |
latency-render and fix nits
|
Fixed nits and changed progress to no-progress 👍 |
| version: 'v', | ||
| help: 'h' | ||
| }, | ||
| default: { | ||
| connections: 10, | ||
| pipelining: 1, | ||
| duration: 10, | ||
| progress: true, |
There was a problem hiding this comment.
Woops, messed up the defaults stuff. will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated some docs, too :)