Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-768: Fix additional ACAS & CReg scientist module search #1159

Merged
merged 2 commits into from
May 10, 2024

Conversation

bffrost
Copy link
Collaborator

@bffrost bffrost commented May 10, 2024

Description

The search behind the Additional ACAS & Additional CReg scientists admin modules was broken by the changes in #148.
This fix reverts the changes, then updates the function call to getCodeTableValuesInternal to match the new expected function signature.

Related Issue

ACAS-768

How Has This Been Tested?

  • Tested these modules in local dev environment and confirmed search behavior before & after fix

@bffrost bffrost requested a review from brianbolt May 10, 2024 18:01
Copy link
Contributor

@brianbolt brianbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt brianbolt merged commit 34cdb07 into release/2024.1.x May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants