Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-770: Additional project grants configuration #1157

Merged
merged 1 commit into from
May 8, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented May 8, 2024

Description

  • Add new configuration server.projects.additionalProjectGrants which confers access to an additional list of projects if the user has access to the project in the key of the configuration.

Example:

server.projects.additionalProjectGrants = {"PROJ-00000001": ["PROJ-00000002", "PROJ-00000003"]}

This would grant access to PROJ-00000002 and PROJ-00000003 to users with access to PROJ-00000001

Related Issue

ACAS-770

How Has This Been Tested?

Test1) Basic test

  • Patched the code change onto a server and granted myself only access to PROJ-00000001 through a CustomerSpecificServerFunction configuration.
  • I set this config:
    server.projects.additionalProjectGrants = {"PROJ-00000001": ["PROJ-00000002"]}

Result:
I could access both "PROJ-00000001" and "PROJ-00000002"

Test2) Same as test 1 but also verify this works when using the projects.filterList configuration

  • I added this config in addition to those in Test1
    server.projects.filterList = ["PROJ-00000001"]

Result:
I could no longer access "PROJ-00000001" but could still access "PROJ-00000002"

@brianbolt brianbolt changed the title ACAS-770: Additional project grants ACAS-770: Additional project grants configuration May 8, 2024
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This seems like as straightforward as possible of an implementation.

@brianbolt brianbolt merged commit e67f8ef into release/2024.1.x May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants