Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-762 pin npm to get fix for too many connections issue #1150

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

bffrost
Copy link
Collaborator

@bffrost bffrost commented Apr 10, 2024

Description

The issue with our builds (ACAS-762) appears to be caused by this npm issue npm/cli#7072 . That issue has been fixed in a new release of npm, but Node hasn't yet made a release. To get our builds unstuck I'd like to pin npm.

Related Issue

ACAS-762

How Has This Been Tested?

  • Ran an arm build on my mac and confirmed the ACAS image is able to run and successfully starts up node
  • Tried running a multi-arch build on my mac docker buildx build --platform=linux/arm64,linux/amd64 . but this got stuck and eventually I cancelled it (after ~8 hours) with this error:
=> [linux/amd64 11/19] RUN     npm install -g gulp@4.0.2 forever@3.0.4 coffeescript@2.5.1                       329.3s
 => => # npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokid
 => => # ar 3 with 15x fewer dependencies                                                                              
 => => # npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated     
 => => # npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokid
 => => # ar 3 with 15x fewer dependencies                                                                              
 => => # qemu: uncaught target signal 11 (Segmentation fault) - core dumped

The real test will be running in our CI environment on GH actions.

@bffrost bffrost requested a review from brianbolt April 10, 2024 02:08
Copy link
Contributor

@brianbolt brianbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt
Copy link
Contributor

Going to go ahead with the merge.

@brianbolt brianbolt merged commit c001b83 into release/2024.1.x Apr 10, 2024
2 checks passed
@brianbolt
Copy link
Contributor

Took a VERY long time but it did complete: https://github.com/mcneilco/acas/actions/runs/8625778116/job/23642909138

@bffrost bffrost deleted the ACAS-762-pin-npm branch April 15, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants