Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACAS-744: Unique newValueKinds #1143

Merged
merged 2 commits into from
Feb 5, 2024
Merged

ACAS-744: Unique newValueKinds #1143

merged 2 commits into from
Feb 5, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Jan 31, 2024

Description

  • Fix to unique ls kinds before uploading so we don't get a conflict

Related Issue

http://jira.schrodinger.com/browse/ACAS-744

How Has This Been Tested?

Upload any 2 of these files and the third will fail with a database constraint error:

LocalSpecificNumber.csv
LocalSpecificClob.csv
LocalSpecificText.csv

Ran this test, modified the code and then ran the test again and verified the error went away.

Uploaded another file with multiple new column types and verified it was registered correctly:
LocalSpecificTextAdditional.csv

@brianbolt brianbolt changed the base branch from release/2023.2.x to release/2024.1.x January 31, 2024 00:45
Copy link
Contributor

@dalejerikson dalejerikson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like (FAILED (errors=3)) 3 unit tests failed

@dalejerikson dalejerikson self-requested a review January 31, 2024 15:02
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt brianbolt merged commit 74f1109 into release/2024.1.x Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants