ACAS-699: Pass list of projects to backend to filter projects by acls #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianbolt
commented
Aug 15, 2023
hhan-schrodinger
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/experiments/protocolCodename/:codeBug description
To reproduce
Create an experiment in a restricted project and login as a user who does not have access to that project.
Go to the protocol browser window and search for the protocol
Scroll down to the section titled: "Experiments using"
Expectation
Experiment in restricted project that the user does not have access to is not displayed
Actual outcome
Experiment in restricted project that the user does not have access to is displayed.
Technical details
This feature relies on the ACAS route here
acas/modules/ServerAPI/src/server/routes/ExperimentServiceRoutes.coffee
Line 32 in b871998
app.get '/api/experiments/protocolCodename/:code', loginRoutes.ensureAuthenticated, exports.experimentsByProtocolCodename
This route does not pay attention to acls and therefore experiments are not filtered.
Related Issue
ACAS-699
How Has This Been Tested?
Ran acasclient tests including new tests added here for this case: mcneilco/acasclient#138