Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foot_role definition for docutils < 0.20 #332

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mitya57
Copy link
Contributor

@mitya57 mitya57 commented Aug 6, 2023

The previous version was equivalent to role=note without quotes, which made the tests fail.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #332 (3875ca9) into develop (61d0195) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #332   +/-   ##
========================================
  Coverage    99.91%   99.91%           
========================================
  Files           53       53           
  Lines         2493     2493           
  Branches       378      378           
========================================
  Hits          2491     2491           
  Misses           1        1           
  Partials         1        1           
Files Changed Coverage Δ
...sphinxcontrib/bibtex/style/referencing/__init__.py 100.00% <ø> (ø)
test/common.py 94.59% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mcmtroffaes mcmtroffaes merged commit 13fb066 into mcmtroffaes:develop Aug 7, 2023
13 checks passed
@mcmtroffaes
Copy link
Owner

Swell, many thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants