Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing tests of config parse - Rebuilt #8

Open
wants to merge 4 commits into
base: additional-config-files
Choose a base branch
from
Open

Enhancing tests of config parse - Rebuilt #8

wants to merge 4 commits into from

Commits on Feb 2, 2024

  1. Additional Configuration File Support (bcoe#436) 

    feat: Adding additional configuration file options
test: unit test for config file detection
test: unit test for config files pass via the cli
test: unit test case for early exit of hideInstrumenteeArgs
test: unit test for Node.js argument handling
fix: bug in spawning of c8 process that dropped coverage significantly
    @mcknasty
    mcknasty committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    dc87eba View commit details
    Browse the repository at this point in the history

  2. refactor: Move config file loading functions into own module 

    Logically these are not part of the argument parsing. They are configuration loading and validation. Having them in the parse-args module was only making the file and the tests harder to work with.

This change only has two semantic differences:
1. The list of known config files names was converted to a const immutable array instead of beating a mutable array returned by a function.
2. The parse-args file is no longer exporting those two internal utility functions, instead the equivalents are coming from a dedicated file.
    Ricky C committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    59dfada View commit details
    Browse the repository at this point in the history

  3. fix: Enhance config file loader to handle more use cases 

    Specifically:
- Handling the cases of empty files and files that have simple forms of improper content.
- Reporting easier to understand errors when the parsers fail.

Adding schema validators was deemed beyond the scope of this particular commit, though notes were added for where they should be added.

Incorporated many of mcknasty's suggestions. However I didn't keep them all, and many other elements were reinterpreted.
    Ricky C committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1b334ed View commit details
    Browse the repository at this point in the history

  4. chore: circleci for matrix builds across win, mac, and linux for node… 

    … v14 - v20
    @mcknasty
    mcknasty authored and Ricky C committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    727e916 View commit details
    Browse the repository at this point in the history