Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Replace KPI cards with dynamic figure functions #648

Merged
merged 32 commits into from
Aug 26, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Aug 23, 2024

Description

  • Replace static KPI cards with KPI card functions
  • Introduce FlexContainer and optimise layout
  • Update README and list out all resources
  • Reduce font-size for KPI card functions
  • Replace area chart with unstacked area chart incl. two traces

After this PR is merged, I will remove the entire demo in a separate PR (so we have the full commit history in this repository) and then the demo will only live in huggingface afterwards.

TO DO:

  • Update screenshots in QA repo

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen self-assigned this Aug 23, 2024
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing. Great job. 🙌

@lingyielia should we advise CNX team to use new KPI cards instead of the hack with bar chart and traces?

Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as usual! 👍

vizro-core/examples/kpi/README.md Outdated Show resolved Hide resolved
vizro-core/examples/kpi/app.py Show resolved Hide resolved
vizro-core/examples/kpi/utils/_helper.py Show resolved Hide resolved
@huong-li-nguyen huong-li-nguyen merged commit 208af57 into main Aug 26, 2024
32 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/replace-kpi-cards branch August 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants