Added lpuart5 and lpuart7 #170
Conversation
Cargo.toml
Outdated
| @@ -66,7 +66,7 @@ members = [ | |||
| [workspace.dependencies] | |||
| imxrt-boot-gen = { version = "0.3.0", features = ["imxrt1060"] } | |||
| imxrt-hal = { version = "0.5.3", features = ["imxrt1060"] } | |||
| imxrt-iomuxc = { version = "0.2.0", features = ["imxrt1060"] } | |||
| imxrt-iomuxc = { version = "0.2.9", features = ["imxrt1060"] } | |||
There was a problem hiding this comment.
Even with this LPUART5 and 7 addition, teensy4-bsp can build its examples with a minimum version of imxrt-iomuxc 0.2.1. Sorry, but I hesitate to force users to adopt a newer version of this package when it doesn't seem necessary.
I removed this from the commit. If you could clarify why we should bump this, I'm happy to reconsider!
There was a problem hiding this comment.
Huh. I dunno; imxrt-rs/imxrt-iomuxc#49 says he published the change adding uart5 in version 0.2.9, so I'd thought we'd need to specify that version. Go figure.
mciantyre
force-pushed
the
feature/lpuarts
branch
from
a9142e5 to
7c47441
Compare
mciantyre
force-pushed
the
feature/lpuarts
branch
from
7c47441 to
a1c2dd8
Compare
There was a problem hiding this comment.
[...] all the lpuart except 5 use pins in pins::common, but lpuart5 uses pins in pins::t41, is that a problem? I'm not sure how to fix it.
Thanks for highlighting this. I don't think it's a problem. These type aliases are a convenience, and not something users need to use. I added a documentation note in the Lpuart5 type alias that this is available for Teensy 4.1 users.
I added lpuart5 and lpuart7. I tested it on my Teensy 4.1 and both work. My main concern is that I see in board.rs, all the lpuart except 5 use pins in pins::common, but lpuart5 uses pins in pins::t41, is that a problem? I'm not sure how to fix it.