Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and 1.8 Prerelease block updates. #161

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Khroki
Copy link
Contributor

@Khroki Khroki commented Mar 11, 2014

EDIT: This pull request is getting pretty big, it contains the following fixes because you can't really choose what goes into a pull request, and multiple edits all edit minecraft.yaml. It's all been tested, dev build available at https://github.com/Khroki/mcedit/releases/tag/v1.0.2
-Quartz and sandstone stairs texture fix
-1.8 Prerelease block updates
-Sapling coord texture fix
-OniOni/hetmankp bugfixes
-Slab rename
-Renderer.py adjustments
-Enaut's python 2.6 compatibility patch
-Aiybe's redstone light fix
-Fixes opaque stained glass

Forgot the quartz stairs texture as it was showing correctly in my test build and 2 sapling coords were flipped, something about the sapling type coding is making them display incorrectly however, not really worried about it though. Sorry for all the minor fixes.
@Lechros
Copy link
Contributor

Lechros commented Mar 11, 2014

lol I made a terrain file with number on each blocks so that i dont have to count blocks everytime i write tex location

@Khroki
Copy link
Contributor Author

Khroki commented Mar 11, 2014

I was tired ok. :P

@Khroki Khroki closed this May 3, 2014
@Khroki Khroki reopened this May 3, 2014
Credits to OniOniOn and hetmankp for finding these.
Added upper wooden slabs, fixed leaf and iron trapdoor naming discrepancies.
@Khroki
Copy link
Contributor Author

Khroki commented May 3, 2014

Committed some of the other minecraft.yaml fixes so I could use them in my build, if it get pulled thanks to onionion and hetmankp for noticing them. Also contains a few other minor things I noticed, there's always something.

@Khroki Khroki changed the title Missing tex fix. Missing tex fix/ naming fixes. May 3, 2014
Old wood slab change to match the wiki.
@Lechros
Copy link
Contributor

Lechros commented May 4, 2014

Just to let you know...
Nobody changed Nether Brick Fence Render Shape for more than a year

@Khroki
Copy link
Contributor Author

Khroki commented May 4, 2014

Yeah, I noticed that, along with a few other blocks. I suspect they need to be added elsewhere in the code as both types of fences are set to FENCE but only one renders correctly. If I get the time I'll try and find it.

@Lechros
Copy link
Contributor

Lechros commented Jun 9, 2014

1 hour left until 0.9.0 blocks

Added a few missing static block mappings for testing purposes
Huh, didn't even notice.
@Khroki
Copy link
Contributor Author

Khroki commented Jun 15, 2014

Kinda annoying every change I commit for personal use ends up on this pull request, makes it overlap with other requests.

@dratini0
Copy link
Contributor

You can make a personal-use branch, if you wish.

Kovács Bálint

On Sun, Jun 15, 2014 at 10:39 PM, Khroki notifications@github.com wrote:

Kinda annoying every change I commit for personal use ends up on this pull
request, makes it overlap with other requests.


Reply to this email directly or view it on GitHub
#161 (comment).

@Khroki
Copy link
Contributor Author

Khroki commented Jun 15, 2014

That's probably a good idea.
Edit: done. I'll leave these edits on this request for now, they're pretty harmless.

Added new blocks
@Khroki
Copy link
Contributor Author

Khroki commented Jun 19, 2014

Now also includes 14w25a's new blocks, some random fixes, and support for my renderer.py update.

@Khroki Khroki changed the title Missing tex fix/ naming fixes. Various fixes and 14w25a minecraft.yaml. Jun 19, 2014
various fixes and updates plus tweaks for updated renderer.py.
Added all the new blocks and fixed a few incorrect textures.
@Khroki Khroki changed the title Various fixes and 14w25a minecraft.yaml. Various fixes and 1.8 Prerelease block updates. Aug 24, 2014
Forgot to add the upper version
Items.py needed an overhaul for 1.7+ compatibility.
@kdart
Copy link

kdart commented Mar 22, 2015

Will this be pulled?

@Lechros
Copy link
Contributor

Lechros commented Mar 24, 2015

Probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants