Make axes(A) return KeyedUnitRanges? #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters
axes(A)to return objects very similar toKeyedArrays, each containing both the parent'saxes(A,d)and the wrapper'saxiskeys(A,d). This is essentially the behaviour of https://github.com/tokazama/AxisIndices.jl, I think.The returned type needs to be
<: AbstractUnitRangeso can't inherit, but many methods can be defined on a newKeyedUnion.The reason to do this is that many functions which call
similar(A, ..., axes(A,3), ...)could automatically propagate keys.The downside is that many functions also specialise onI don't think that's true.Base.OneTo(n), so for example this tends to make lots of unnecessaryOffsetArrays.