Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI workflow #3

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Setup CI workflow #3

merged 6 commits into from
Oct 19, 2021
+1,035 −597

Conversation

mhiro2
Copy link
Collaborator

@mhiro2 mhiro2 commented Oct 19, 2021 •
edited
Loading

WHY

This repository was not well maintained and was outdated.
So we needed to update Python packages and create a CI workflow for continuous development.

WHAT

  • Update pyproject.toml to show proper information in PyPI. 3b1d46f
  • Update outdated python packages. a3bd1bf
  • Add py.typed file for PEP-561 support. 5f6ca92
    • Type hint is not used much in this repository, but I think it needs to be added in the future.
  • Apply flake8, black and isort. 1884638
  • Fix intersection tests to support latest apache-beam version. b8c5466
  • Add CI workflow with tox. 2e623c0

@mhiro2 mhiro2 added the enhancement New feature or request label Oct 19, 2021
@mhiro2 mhiro2 self-assigned this Oct 19, 2021
@mhiro2 mhiro2 requested a review from minikomi October 19, 2021 06:27
minikomi
minikomi reviewed Oct 19, 2021
View reviewed changes
tox.ini Show resolved Hide resolved
minikomi
minikomi approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@minikomi minikomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

minikomi
minikomi reviewed Oct 19, 2021
View reviewed changes
.github/workflows/ci.yml
run: |
python -m pip install poetry tox
- name: Test with tox
run: poetry run tox -e py,black,flake8,isort
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conf-platform

Running tox -e <platform_name> will run commands for a particular platform and skip the rest

@mhiro2 mhiro2 merged commit 5522381 into main Oct 19, 2021
@mhiro2 mhiro2 deleted the mhiro2/setup-ci-workflow branch October 19, 2021 07:54
@mhiro2 mhiro2 added the CI label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikomi minikomi minikomi approved these changes

Assignees

@mhiro2 mhiro2

Labels
CI enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhiro2 @minikomi