Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cleanup Admin columns and default values #2236

Merged
merged 5 commits into from
Oct 8, 2024
Merged

chore: Cleanup Admin columns and default values #2236

merged 5 commits into from
Oct 8, 2024

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Oct 8, 2024 •
edited
Loading

Main goal of this PR is to correct default value for evergreen_content when creating a screen use the Add New Screen modal. I also saw an opportunity to clean up/fix columns shown on the app filter tabs.

@cmaddox5 cmaddox5 requested a review from a team as a code owner October 8, 2024 15:12
digitalcora
digitalcora approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, a couple non-blocking comments.

assets/src/components/admin/admin_add_modal.tsx Outdated Show resolved Hide resolved
assets/src/components/admin/admin_add_modal.tsx Outdated Show resolved Hide resolved
@cmaddox5 cmaddox5 merged commit 857ebd8 into main Oct 8, 2024
11 checks passed
@cmaddox5 cmaddox5 deleted the cm/cleanup-admin-columns branch October 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalcora digitalcora digitalcora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaddox5 @digitalcora