Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed D branch headsign. #1897

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fixed D branch headsign. #1897

merged 1 commit into from
Oct 31, 2023

Conversation

cmaddox5
Copy link
Contributor

Asana task: [frontend] Terminal station closure causes JS errors

This ended up being a server issue. When building the banner, we use the North Station & North icon in the banner but the headsign was only North Station. Because the key was missing, the svg filename was nil.

  • Tests added?

@cmaddox5 cmaddox5 requested review from a team and hannahpurcell and removed request for a team October 26, 2023 18:57
@github-actions
Copy link

Coverage of commit ba0d5ad

Summary coverage rate:
  lines......: 44.0% (2673 of 6080 lines)
  functions..: 40.9% (978 of 2394 functions)
  branches...: no data found

Files changed coverage rate:
                                                                       |Lines       |Functions  |Branches    
  Filename                                                             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================================================================
  lib/screens/v2/widget_instance/reconstructed_alert.ex                |88.4%    276| 100%    34|    -      0

Download coverage report

hannahpurcell
hannahpurcell approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmaddox5 cmaddox5 merged commit 6e426ce into prefare-alerts Oct 31, 2023
4 checks passed
@cmaddox5 cmaddox5 deleted the cm/north-station-north-banner-fix branch October 31, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees

@cmaddox5 cmaddox5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaddox5 @hannahpurcell