[feature] Crowding widget backend #1834

hannahpurcell · 2023-08-17T18:56:30Z

Asana task: OL Crowding: start backend logic

Tests are in-progress. This covers the backend logic that determines the conditions for showing the crowding widget, and serializes it.

Some of the changes are just renaming, or adding "Triptych" to an array of app names

Tests added?

…candidategenerator

…dget

github-actions · 2023-08-17T20:21:40Z

Coverage of commit `77f6948`

Summary coverage rate:
  lines......: 41.2% (2269 of 5506 lines)
  functions..: 42.5% (1037 of 2438 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/v2/train_crowding.ex                                  |20.0%      5|50.0%     4|    -      0
  lib/screens/config/v2/triptych.ex                                        | 100%      1| 100%     2|    -      0
  lib/screens/predictions/prediction.ex                                    |33.3%      9|80.0%     5|    -      0
  lib/screens/stops/stop.ex                                                |36.1%     83|48.1%    27|    -      0
  lib/screens/v2/candidate_generator/triptych.ex                           |10.0%     10|16.7%     6|    -      0
  lib/screens/v2/candidate_generator/widgets/evergreen.ex                  | 0.0%      3| 0.0%     3|    -      0
  lib/screens/v2/candidate_generator/widgets/train_crowding.ex             |83.3%     24|50.0%     8|    -      0
  lib/screens/v2/widget_instance/train_crowding.ex                         |64.0%     25|92.3%    13|    -      0
  lib/screens/vehicles/parser.ex                                           | 0.0%     16| 0.0%     8|    -      0
  lib/screens/vehicles/vehicle.ex                                          |25.0%      4|66.7%     3|    -      0

Download coverage report

cmaddox5

So sorry for the delay! Have a few questions, suggestions, and comments.

lib/screens/config/v2/train_crowding.ex

lib/screens/v2/candidate_generator/widgets/train_crowding.ex

lib/screens/vehicles/parser.ex

lib/screens/v2/widget_instance/train_crowding.ex

github-actions · 2023-08-24T19:13:53Z

Coverage of commit `8cf8bad`

Summary coverage rate:
  lines......: 41.2% (2274 of 5517 lines)
  functions..: 42.6% (1038 of 2439 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/v2/train_crowding.ex                                  |20.0%      5|50.0%     4|    -      0
  lib/screens/config/v2/triptych.ex                                        | 100%      1| 100%     2|    -      0
  lib/screens/predictions/prediction.ex                                    |33.3%      9|80.0%     5|    -      0
  lib/screens/stops/stop.ex                                                |36.1%     83|48.1%    27|    -      0
  lib/screens/v2/candidate_generator/triptych.ex                           |10.0%     10|16.7%     6|    -      0
  lib/screens/v2/candidate_generator/widgets/evergreen.ex                  | 0.0%      3| 0.0%     3|    -      0
  lib/screens/v2/candidate_generator/widgets/train_crowding.ex             |83.3%     24|50.0%     8|    -      0
  lib/screens/v2/widget_instance/train_crowding.ex                         |67.7%     31|92.9%    14|    -      0
  lib/screens/vehicles/parser.ex                                           | 0.0%     21| 0.0%     8|    -      0
  lib/screens/vehicles/vehicle.ex                                          |25.0%      4|66.7%     3|    -      0

Download coverage report

github-actions · 2023-08-24T19:30:02Z

Coverage of commit `84054cd`

Summary coverage rate:
  lines......: 41.2% (2275 of 5519 lines)
  functions..: 42.6% (1039 of 2440 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/v2/train_crowding.ex                                  |20.0%      5|50.0%     4|    -      0
  lib/screens/config/v2/triptych.ex                                        | 100%      1| 100%     2|    -      0
  lib/screens/predictions/prediction.ex                                    |33.3%      9|80.0%     5|    -      0
  lib/screens/stops/stop.ex                                                |36.1%     83|48.1%    27|    -      0
  lib/screens/v2/candidate_generator/triptych.ex                           |10.0%     10|16.7%     6|    -      0
  lib/screens/v2/candidate_generator/widgets/evergreen.ex                  | 0.0%      3| 0.0%     3|    -      0
  lib/screens/v2/candidate_generator/widgets/train_crowding.ex             |83.3%     24|50.0%     8|    -      0
  lib/screens/v2/widget_instance/train_crowding.ex                         |66.7%     33|93.3%    15|    -      0
  lib/screens/vehicles/parser.ex                                           | 0.0%     21| 0.0%     8|    -      0
  lib/screens/vehicles/vehicle.ex                                          |25.0%      4|66.7%     3|    -      0

Download coverage report

cmaddox5

A couple of questions, but this looks great!

lib/screens/v2/widget_instance/train_crowding.ex

lib/screens/v2/candidate_generator/widgets/train_crowding.ex

github-actions · 2023-08-25T16:04:45Z

Coverage of commit `98e3fc2`

Summary coverage rate:
  lines......: 41.2% (2276 of 5520 lines)
  functions..: 42.6% (1039 of 2440 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/v2/train_crowding.ex                                  |20.0%      5|50.0%     4|    -      0
  lib/screens/config/v2/triptych.ex                                        | 100%      1| 100%     2|    -      0
  lib/screens/predictions/prediction.ex                                    |33.3%      9|80.0%     5|    -      0
  lib/screens/stops/stop.ex                                                |36.1%     83|48.1%    27|    -      0
  lib/screens/v2/candidate_generator/triptych.ex                           |10.0%     10|16.7%     6|    -      0
  lib/screens/v2/candidate_generator/widgets/evergreen.ex                  | 0.0%      3| 0.0%     3|    -      0
  lib/screens/v2/candidate_generator/widgets/train_crowding.ex             |84.0%     25|50.0%     8|    -      0
  lib/screens/v2/widget_instance/train_crowding.ex                         |66.7%     33|93.3%    15|    -      0
  lib/screens/vehicles/parser.ex                                           | 0.0%     21| 0.0%     8|    -      0
  lib/screens/vehicles/vehicle.ex                                          |25.0%      4|66.7%     3|    -      0

Download coverage report

…screens into hp/crowding-widget-backend

github-actions · 2023-08-25T19:29:13Z

Coverage of commit `b58b32e`

Summary coverage rate:
  lines......: 41.2% (2276 of 5520 lines)
  functions..: 42.6% (1039 of 2440 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/v2/train_crowding.ex                                  |20.0%      5|50.0%     4|    -      0
  lib/screens/config/v2/triptych.ex                                        | 100%      1| 100%     2|    -      0
  lib/screens/predictions/prediction.ex                                    |33.3%      9|80.0%     5|    -      0
  lib/screens/stops/stop.ex                                                |36.1%     83|48.1%    27|    -      0
  lib/screens/v2/candidate_generator/triptych.ex                           |10.0%     10|16.7%     6|    -      0
  lib/screens/v2/candidate_generator/widgets/evergreen.ex                  | 0.0%      3| 0.0%     3|    -      0
  lib/screens/v2/candidate_generator/widgets/train_crowding.ex             |84.0%     25|50.0%     8|    -      0
  lib/screens/v2/widget_instance/train_crowding.ex                         |66.7%     33|93.3%    15|    -      0
  lib/screens/vehicles/parser.ex                                           | 0.0%     21| 0.0%     8|    -      0
  lib/screens/vehicles/vehicle.ex                                          |25.0%      4|66.7%     3|    -      0

Download coverage report

cmaddox5

🚀

hannahpurcell added 9 commits August 8, 2023 15:26

Stubbed out template & ol crowding widget config

a97f1d6

Rename file, added route_id field so it can work for various routes

8a8e11e

Adjust triptych config, added screen type to stop file and evergreen …

a2a16e1

…candidategenerator

Change parsing of vehicle info, add logic for generating crowding widget

ce2a775

Add "enabled" flag to widget; if no predictions, turn off crowding wi…

dc4e2fd

…dget

formatting

1da2033

If an alert makes a temp terminal, suppress widget

760acc1

Moved prediction logic to prediction file

8d532b7

Added candidate_gen, template tests

c846217

hannahpurcell requested a review from cmaddox5 August 17, 2023 18:56

hannahpurcell assigned cmaddox5 Aug 17, 2023

hannahpurcell added 3 commits August 17, 2023 15:49

WidgetInstance test

464791e

formatting

7f5b42b

credo fixes

77f6948

cmaddox5 reviewed Aug 24, 2023

View reviewed changes

cmaddox5 assigned hannahpurcell and unassigned cmaddox5 Aug 24, 2023

hannahpurcell added 7 commits August 24, 2023 10:48

Using integer slots instead of decimals

e2f6b1d

Update carriage serializer with known data structure

70b617c

Mislabeled value

acdd245

Removed unneeded / inaccurate fields in serializer

4c8fec7

use not instead of !

a71aa03

Removed unneeded values from serializer

cb96568

Two vehicle parsers: bus & subway. Added occupancy_status types

8cf8bad

hannahpurcell added 2 commits August 24, 2023 15:22

Re-order function defs, handle nil carriages for a vehicle

e218fcd

Formatting

84054cd

hannahpurcell assigned cmaddox5 and unassigned hannahpurcell Aug 24, 2023

cmaddox5 approved these changes Aug 24, 2023

View reviewed changes

lib/screens/v2/widget_instance/train_crowding.ex Show resolved Hide resolved

lib/screens/v2/widget_instance/train_crowding.ex Show resolved Hide resolved

cmaddox5 assigned hannahpurcell and unassigned cmaddox5 Aug 24, 2023

hannahpurcell commented Aug 25, 2023

View reviewed changes

lib/screens/v2/candidate_generator/widgets/train_crowding.ex Show resolved Hide resolved

Added another data check to the candidate generator

98e3fc2

hannahpurcell added 2 commits August 25, 2023 15:20

Shouldn't remove parent_stop_id from vehicles

dbe8123

Merge branch 'hp/crowding-widget-backend' of https://github.com/mbta/…

b58b32e

…screens into hp/crowding-widget-backend

hannahpurcell requested a review from cmaddox5 August 25, 2023 19:29

cmaddox5 approved these changes Aug 25, 2023

View reviewed changes

hannahpurcell merged commit cd4f330 into master Aug 25, 2023
2 checks passed

hannahpurcell deleted the hp/crowding-widget-backend branch August 25, 2023 19:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Crowding widget backend #1834

[feature] Crowding widget backend #1834

hannahpurcell commented Aug 17, 2023 •

edited

Loading

github-actions bot commented Aug 17, 2023

cmaddox5 left a comment

github-actions bot commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

cmaddox5 left a comment

github-actions bot commented Aug 25, 2023

github-actions bot commented Aug 25, 2023

cmaddox5 left a comment

[feature] Crowding widget backend #1834

[feature] Crowding widget backend #1834

Conversation

hannahpurcell commented Aug 17, 2023 • edited Loading

github-actions bot commented Aug 17, 2023

Coverage of commit 77f6948

cmaddox5 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 24, 2023

Coverage of commit 8cf8bad

github-actions bot commented Aug 24, 2023

Coverage of commit 84054cd

cmaddox5 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 25, 2023

Coverage of commit 98e3fc2

github-actions bot commented Aug 25, 2023

Coverage of commit b58b32e

cmaddox5 left a comment

Choose a reason for hiding this comment

hannahpurcell commented Aug 17, 2023 •

edited

Loading

Coverage of commit `77f6948`

Coverage of commit `8cf8bad`

Coverage of commit `84054cd`

Coverage of commit `98e3fc2`

Coverage of commit `b58b32e`