Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[refactor] SVG better bundling feature branch" #1813

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

hannahpurcell
Copy link
Contributor

I didn't appropriately test this. I'm using one of these "bundled" icons in the pre-fare text resize logic now, and it revealed that the svgs are not loading quickly enough with this method. I have to re-evaluate this solution.

Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I didn't think to test that either, so sorry for letting this get by. If you need any help finding a solution, let me know.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Coverage of commit 7c38660

Summary coverage rate:
  lines......: 41.2% (2239 of 5428 lines)
  functions..: 42.6% (1021 of 2397 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@hannahpurcell hannahpurcell merged commit f64a208 into master Jul 6, 2023
4 checks passed
@hannahpurcell hannahpurcell deleted the revert-1806-hp/svg-better-bundling branch September 5, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants