Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Add github package upload workflow #14

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Conversation

EmmaSimon
Copy link

@EmmaSimon EmmaSimon commented May 25, 2023

Summary:

Add packaging to the CI/CD, this adds a workflow to upload a built package to the github packages maven repository. This can then be used by the OTP repo to pull MBTA changes directly in the pom file, rather than doing a special case download and local install of this fork. This may require shading to function properly once added to the OTP pom. This was tested and ran successfully on this feature branch.

⚠️ Don't merge this until the version has been updated in the trip planner repo, and until dependencies have been confirmed to work there. (One of the downsides of the existing system is that OTP is just pulling the latest commit of the branch rather than a specific version)

Ticket: Use github packages for the onebusaway-gtfs-modules library

Expected behavior:

The github workflow uploads a package which can be used as a dependency in other repos.

EmmaSimon added 3 commits May 10, 2023 15:03
The maven install was failing because there were a few goals that were
throwing errors. This resolves those errors by adding a license header,
removing a test that started failing when run in Java 17, and ignoring
the build script in the license header checker. The reason the build
script was succeeding is because it skips all the failing checks.
This was preventing the pipeline from running due to a permission error.
@EmmaSimon EmmaSimon requested a review from lboyarsky May 25, 2023 16:02
Copy link

@lboyarsky lboyarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I've also included a non-blocking question about the test being removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants