refactor: alerts page layout #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from back when we had a different version of the schedules pages mbta/dotcom-legacy@7e67af7#diff-51cf935207e8735af3009ef42d1c254428b7219e66b441d45948aa5cb04f59c3
anthonyshull
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Precursor to Service Alerts page | Refine Station and Service Alerts section
Refactored the alerts "show" template into a layout. I used named slots to control what goes into the sidebar, since this will change for the subway service alerts (the timeframe filters will be removed). Anyways, I'm hoping it'll make it easier to swap in/out the differing content between subway and the other modes (which will remain the same). Visually, this should be a no-op.