Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't warn that KinoLiveComponent import is unused #2370

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

joshlarson
Copy link
Contributor

Removes this warning, which shows up in any and all test output:

     warning: unused import KinoLiveComponent.Plug
     │
 264 │   import KinoLiveComponent.Plug, only: [allow_insecure_connection: 2]
     │   ~
     │
     └─ lib/dotcom_web/router.ex:264:3

The import is actually used (in :dev and :dev only), but something about the if Mix.env() == :dev check means that when Mix.env() is :test, it thinks that the import isn't.


No ticket.

@joshlarson joshlarson requested a review from a team as a code owner February 7, 2025 21:02
@joshlarson joshlarson enabled auto-merge (squash) February 7, 2025 21:02
@joshlarson joshlarson merged commit 025f5f9 into main Feb 7, 2025
20 checks passed
@joshlarson joshlarson deleted the jdl/fix-kino-live-component-warning branch February 7, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants