feat(Live.TripPlanner): handle OTP timeouts #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
This is a good change. I think we'd probably benefit from improving the error message, since I imagine riders aren't actually concerned about whether we can connect to "Open Trip Planner", so much as being concerned about whether we can plan a trip.
☝️ is non-blocking because having the error message at all is such a vast improvement over infinite spinner that it's worth rolling forward here.
|
We had a better fallback error, didn't we? Lemme see if I can pull that up.. |
yaaayyyy, thanks for pointing this out @joshlarson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we weren't pattern matching to handle the
%Req.TransportError{reason: :timeout}we were receiving.