cleanup: Add @spec annotations to Dotcom.SystemStatus.Subway #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
reviewed
Feb 4, 2025
thecristen
reviewed
Feb 4, 2025
thecristen
reviewed
Feb 4, 2025
joshlarson
force-pushed
the
jdl/system-status/flowchart-typespecs
branch
from
bb8dec0 to
c00f06a
Compare
joshlarson
force-pushed
the
jdl/system-status/flowchart-typespecs
branch
from
d5960a6 to
2abf5d9
Compare
thecristen
requested changes
Feb 5, 2025
lib/dotcom/system_status/subway.ex
Outdated
| @type status_time() :: :current | {:future, DateTime.t()} | ||
|
|
||
| @type status_entry() :: %{ | ||
| status: atom(), |
There was a problem hiding this comment.
This atom's:normal or Alerts.Alert.effect() right? I'd rather that be described explicitly... even better if we could have a type that's limited to the effects we care about.
joshlarson
force-pushed
the
jdl/system-status/flowchart-typespecs
branch
from
2abf5d9 to
e703c2e
Compare
|
@thecristen PTALA e703c2e 🙏 |
thecristen
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to:
Specifically, this comment.