Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix dialyzer/dialyxir config #2359

Merged
merged 5 commits into from
Feb 4, 2025
Merged

fix: Fix dialyzer/dialyxir config #2359

merged 5 commits into from
Feb 4, 2025

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Feb 4, 2025

A few fixes:

  • Uses the default dialyzer ignore file location and format
  • Fails the CI task on dialyzer failure

Example build failure

A few fixes:
- Uses the default dialyzer ignore file location and format
- Fails the CI task on dialyzer failure
@joshlarson joshlarson marked this pull request as ready for review February 4, 2025 18:27
@joshlarson joshlarson requested a review from a team as a code owner February 4, 2025 18:27
@joshlarson joshlarson enabled auto-merge (squash) February 4, 2025 18:27
@joshlarson joshlarson disabled auto-merge February 4, 2025 18:56
@@ -159,7 +159,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-all
- uses: mbta/actions/dialyzer@v2
- uses: mix dialyzer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshlarson Want run: here rather than uses: :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Thanks! 🤦

@joshlarson joshlarson enabled auto-merge (squash) February 4, 2025 21:22
@joshlarson joshlarson requested a review from thecristen February 4, 2025 21:27
@joshlarson joshlarson merged commit 995eb2f into main Feb 4, 2025
23 checks passed
@joshlarson joshlarson deleted the jdl/fix-dialyxir branch February 4, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants