refactor: Convert TripPlannerResultsSection to a function component #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
commented
Dec 9, 2024
| /> | ||
| </div> | ||
| """ | ||
| end | ||
|
|
||
| @impl true | ||
| def handle_event("set_itinerary_group_index", %{"index" => index_str}, socket) do |
There was a problem hiding this comment.
One of the reasons I originally made everything live components was because of these event names; it felt a bit odd to have the event names spread around the way they are - the handler is here, but the thing that generates the event is tucked away in trip_planner_results_section (or for the set_itinerary_index event, tucked away in itinerary_detail).
Is that okay? Do we want to pass the event names around as attrs? Some other solution?
There was a problem hiding this comment.
Realistically, I could see the answer to this being a follow-up, rather than trying to "fix" it in this PR, but I am interested in what our overarching vision for this type of question is.
anthonyshull
approved these changes
Dec 9, 2024
joshlarson
deleted the
jdl/function-component-for-trip-planner-results-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to this comment, which suggested biasing much more strongly towards function components, and this PR, which consolidated the
TripPlannerResultsSectionstate into a single variable.User-facing-wise, this should be a pure refactor, so no visible changes.
No ticket.