chore: add integrity attribute to external links #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
changed the title
joshlarson
approved these changes
Nov 25, 2024
thecristen
added a commit
that referenced
this pull request
Nov 27, 2024
* chore: convert root template to .heex * add a script * chore: add integrity attribute to external links (#2236) * chore: avoid conflict by not importing static_integrity from the router helpers * feat: add integrity attribute to external script and style sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Resolve BitSight audit issues > Integrity Attribute | Web Application Security & Resolve BitSight audit issues > Integrity Attribute | Web Application Security
Uses
Phoenix.VerifiedRoutes.static_integrity/2to add theintegrityattribute to<script>and<link>tags.