Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the new metro map component to the preview trip planner #2208

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add the new metro map component to the preview trip planner #2208

wants to merge 11 commits into from

Conversation

anthonyshull
Copy link
Contributor

Screenshot Capture - 2024-10-30 - 13-09-00

Adding and removing markers works. When all markers are removed, the map recenters itself.

@anthonyshull anthonyshull marked this pull request as ready for review October 31, 2024 19:35
@anthonyshull anthonyshull requested a review from a team as a code owner October 31, 2024 19:35
joshlarson
joshlarson reviewed Nov 1, 2024
View reviewed changes
test/dotcom_web/live/trip_planner_test.exs
@@ -65,18 +65,6 @@ defmodule DotcomWeb.Live.TripPlannerTest do
end

test "pushes updated location to the map", %{view: view} do
updated_location = %{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just delete the test, rather than leaving it empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter? Leaving it there signals we're going to come back and do this later.

joshlarson
joshlarson requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a few comments in. I think all of them (at least discussing them) are approval-blockers for me.

@anthonyshull anthonyshull added the dev-blue Deploy to dev-blue label Nov 1, 2024
@anthonyshull
Copy link
Contributor Author

I replaced the integers with atoms if that makes it easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlarson joshlarson Awaiting requested review from joshlarson

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dev-blue Deploy to dev-blue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyshull @joshlarson