Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from ExAws to aws-elixir #2167

Merged
merged 17 commits into from
Sep 11, 2024
Merged

refactor: migrate from ExAws to aws-elixir #2167

merged 17 commits into from
Sep 11, 2024

Conversation

thecristen
Copy link
Collaborator

Not sure if this is a better choice. Some things I liked about aws-elixir:

  • It's got types, super helpful for understanding the particulars of each function's inputs and outputs (I had to dig into the generated source code, but maybe still better than wading through AWS docs)
  • Results come out already parsed, so no more reading responses / decoding JSON ourselves
  • It's got literally everything (also a slight con - it takes a noticeably longer time to compile) - no crafting bespoke configurations for more generic functions

And I'll have to deploy this and poke around to ensure I didn't break things. We don't use AWS a ton, but the few things we do with it are fairly important.

This affects:

  • searching for locations (AWS Location Service)
  • saving and surfacing bus stop change alerts (AWS S3)
  • mailing tickets to IRIS/HEAT (AWS Simple Email Service)

@thecristen thecristen added the dev-green Deploy to dev-green label Aug 30, 2024
@thecristen thecristen marked this pull request as ready for review September 3, 2024 16:08
@thecristen thecristen requested a review from a team as a code owner September 3, 2024 16:08
@thecristen thecristen removed the dev-green Deploy to dev-green label Sep 4, 2024
@@ -191,7 +191,7 @@ config :dotcom, DotcomWeb.ViewHelpers,

config :recaptcha,
public_key: System.get_env("RECAPTCHA_PUBLIC_KEY"),
secret: System.get_env("RECAPTCHA_PRIVATE_KEY")
secret: System.get_env("RECAPTCHA_PRIVATE_KEY", "6LeIxAcTAAAAAGG-vFI1TnRWxMZNFuojJ4WifJWe")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be here?

Copy link
Collaborator Author

@thecristen thecristen Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, missed commenting on this. We could either write it here or require devs and CI to have this value saved to this environment variable, it's needed for tests to pass. It's the publicly available one for testing listed here: https://developers.google.com/recaptcha/docs/faq#id-like-to-run-automated-tests-with-recaptcha.-what-should-i-do

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's public then we can just keep it as a default.

@thecristen thecristen merged commit acd4d50 into main Sep 11, 2024
17 checks passed
@thecristen thecristen deleted the cbj/aws-elixir branch September 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants