-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate from ExAws to aws-elixir #2167
Conversation
426a870
to
c25aa10
Compare
c25aa10
to
f7b0e5f
Compare
f7b0e5f
to
23dd457
Compare
23dd457
to
061d0b9
Compare
52610eb
to
ba405ba
Compare
@@ -191,7 +191,7 @@ config :dotcom, DotcomWeb.ViewHelpers, | |||
|
|||
config :recaptcha, | |||
public_key: System.get_env("RECAPTCHA_PUBLIC_KEY"), | |||
secret: System.get_env("RECAPTCHA_PRIVATE_KEY") | |||
secret: System.get_env("RECAPTCHA_PRIVATE_KEY", "6LeIxAcTAAAAAGG-vFI1TnRWxMZNFuojJ4WifJWe") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, missed commenting on this. We could either write it here or require devs and CI to have this value saved to this environment variable, it's needed for tests to pass. It's the publicly available one for testing listed here: https://developers.google.com/recaptcha/docs/faq#id-like-to-run-automated-tests-with-recaptcha.-what-should-i-do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's public then we can just keep it as a default.
Not sure if this is a better choice. Some things I liked about aws-elixir:
And I'll have to deploy this and poke around to ensure I didn't break things. We don't use AWS a ton, but the few things we do with it are fairly important.
This affects: