Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16 ability to change steam userid #18

Merged
merged 5 commits into from
Feb 9, 2021

Conversation

mbround18
Copy link
Owner

@mbround18 mbround18 commented Feb 9, 2021

Description

Contributions

  • Changed to starting the container as root
  • Added init script as root.
  • Added log blocks for clarity.
  • Added more context to entry point.

Checklist

  • I added one or multiple labels which best describes this PR.
  • I have tested the changes locally.
  • This PR has a reviewer on it.
  • I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@mbround18 mbround18 added docker Tag if its related to docker github Tag if its related to github help wanted Extra attention is needed labels Feb 9, 2021
@mbround18
Copy link
Owner Author

mbround18 commented Feb 9, 2021

I would really appreciate if someone who is using a separate user ID could assist in testing this functionality.

git checkout mbround18/16-ability-to-change-steam-userid

# Edit the docker-compose.yml then
docker-compose up --build

@Fabiryn
Copy link

Fabiryn commented Feb 9, 2021

tested it locally. The generated files now have the right user id.
server starts normally valheim_1 | 02/08/2021 23:51:45: Game server connected

Not sure if this is an issue with the changes but, TZ doesn't get respected. I'll test it later with the official release.

@Fabiryn
Copy link

Fabiryn commented Feb 9, 2021

So the TZ environment only seems to work for the init.sh logs. It also doesn't work with the released version. So I add a new issue for that.

server startup:

valheim_1  | ###########################################################################
valheim_1  | Valheim Server - Tue Feb  9 12:07:54 CET 2021
valheim_1  |
valheim_1  | Initializing your container...
valheim_1  | ###########################################################################
valheim_1  |
valheim_1  | [Valheim][root]: Switching UID and GID
valheim_1  | [Valheim][root]: Setting up file systems
valheim_1  | [Valheim][root]: Launching as steam...
valheim_1  |
valheim_1  | ###########################################################################
valheim_1  | Valheim Server - Tue Feb  9 03:07:55 PST 2021
valheim_1  | STEAM_UID 1000 - STEAM_GUID 1000
valheim_1  |
valheim_1  | Installing Valheim via Odin
valheim_1  |
valheim_1  | ###########################################################################

...

valheim_1  | [ODIN][INFO]  - Successfully installed Valheim!
valheim_1  | [Valheim][steam]: Herding Cats...
valheim_1  | [Valheim][steam]: Starting server...
valheim_1  | [ODIN][INFO]  - Setting up start scripts...
valheim_1  | [ODIN][INFO]  - Looking for burial mounds...
valheim_1  | [ODIN][INFO]  - Successfully written /home/steam/valheim/start_server_rusty.sh
valheim_1  | [ODIN][INFO]  - Created the /home/steam/valheim/start_server_rusty.sh script successfully!
valheim_1  | [ODIN][INFO]  - Successfully set /home/steam/valheim/start_server_rusty.sh to executable
valheim_1  | [ODIN][INFO]  - Successfully set /home/steam/valheim/start_server_rusty.sh to executable!
valheim_1  | [ODIN][INFO]  - Exit with code exit code: 0
valheim_1  | [ODIN][INFO]  - Server has started...
valheim_1  | [ODIN][INFO]  - Check out ./output.log for the logs.
valheim_1  | [ODIN][INFO]  - Keep an eye out for "Game server connected" and you server should be live!
valheim_1  |
valheim_1  |
valheim_1  | Valheim Server Started...
valheim_1  |
valheim_1  | Keep an eye out for 'Game server connected' in the log!
valheim_1  | (this indicates its online without any errors.)
valheim_1  |
valheim_1  |
valheim_1  | ###########################################################################

...

valheim_1  | 02/09/2021 03:08:20: Game server connected

@mbround18
Copy link
Owner Author

@Fabiryn that should be an easy fix :) ill make the change at lunch and toss it up

@mbround18
Copy link
Owner Author

Alright, my latest push has the timezone fixes. From my testing, it sets the timezone correctly and when I exec into the system it now has the correct timezone. (Tested with PST, CST, and EST)

@mbround18 mbround18 added documentation Changes only affect the documentation enhancement New feature or request odin Tag if theres an issue with odin labels Feb 9, 2021
@mbround18 mbround18 merged commit 1d97f18 into main Feb 9, 2021
@mbround18 mbround18 deleted the mbround18/16-ability-to-change-steam-userid branch February 9, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Tag if its related to docker documentation Changes only affect the documentation enhancement New feature or request github Tag if its related to github help wanted Extra attention is needed odin Tag if theres an issue with odin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants