Open parents in addToSelection

docs/_entries/general/changelog.md

@@ -6,6 +6,7 @@ name: changelog
 #### Development version
 
 -   Issue #735: compile to es6
+-   Issue #766: open parent nodes in the addToSelection method (thanks to Tmgarcia)
 
 #### 1.7.5 (october 21 2023)
 

src/test/jqTree/methods.test.ts

@@ -134,23 +134,29 @@ describe("addToSelection", () => {
     given("child1", () => given.$tree.tree("getNodeByNameMustExist", "child1"));
     given("child2", () => given.$tree.tree("getNodeByNameMustExist", "child2"));
 
-    beforeEach(() => {
+    it("selects the nodes", () => {
         given.$tree.tree({
             autoOpen: true,
             data: exampleData,
         });
 
         given.$tree.tree("addToSelection", given.child1);
         given.$tree.tree("addToSelection", given.child2);
-    });
 
-    it("selects the nodes", () => {
         expect(given.$tree.tree("getSelectedNodes")).toEqual(
             expect.arrayContaining([given.child1, given.child2]),
         );
     });
 
     it("renders the nodes correctly", () => {
+        given.$tree.tree({
+            autoOpen: true,
+            data: exampleData,
+        });
+
+        given.$tree.tree("addToSelection", given.child1);
+        given.$tree.tree("addToSelection", given.child2);
+
         expect(given.$tree).toHaveTreeStructure([
             expect.objectContaining({
                 name: "node1",
@@ -172,6 +178,20 @@ describe("addToSelection", () => {
             }),
         ]);
     });
+
+    it("opens the parent node when it's closed", () => {
+        given.$tree.tree({
+            autoOpen: false,
+            data: exampleData,
+        });
+
+        const node1 = given.$tree.tree("getNodeByNameMustExist", "node1");
+        expect(node1.is_open).toBeFalsy();
+
+        given.$tree.tree("addToSelection", given.child1);
+
+        expect(node1.is_open).toBe(true);
+    });
 });
 
 describe("appendNode", () => {
@@ -1207,6 +1227,15 @@ describe("selectNode", () => {
             expect(given.$tree.tree("getSelectedNode")).toBeFalse();
         });
     });
+
+    it("opens the parent node when it's closed", () => {
+        expect(given.node1.is_open).toBeFalsy();
+
+        const child1 = given.$tree.tree("getNodeByNameMustExist", "child1");
+        given.$tree.tree("selectNode", child1);
+
+        expect(given.node1.is_open).toBe(true);
+    });
 });
 
 describe("setOption", () => {

src/tree.jquery.ts

@@ -426,6 +426,7 @@ export class JqTreeWidget extends MouseWidget<JQTreeOptions> {
         }
 
         this.selectNodeHandler.addToSelection(node);
+        this.openParents(node);
 
         this._getNodeElementForNode(node).select(
             mustSetFocus === undefined ? true : mustSetFocus,
@@ -1079,14 +1080,6 @@ export class JqTreeWidget extends MouseWidget<JQTreeOptions> {
             }
         };
 
-        const openParents = (): void => {
-            const parent = node.parent;
-
-            if (parent && parent.parent && !parent.is_open) {
-                this.openNode(parent, false);
-            }
-        };
-
         if (!canSelect()) {
             return;
         }
@@ -1108,7 +1101,7 @@ export class JqTreeWidget extends MouseWidget<JQTreeOptions> {
                 node,
                 deselected_node: deselectedNode,
             });
-            openParents();
+            this.openParents(node);
         }
 
         saveState();
@@ -1353,6 +1346,14 @@ export class JqTreeWidget extends MouseWidget<JQTreeOptions> {
             $treeElement,
         });
     }
+
+    private openParents(node: Node) {
+        const parent = node.parent;
+
+        if (parent && parent.parent && !parent.is_open) {
+            this.openNode(parent, false);
+        }
+    }
 }
 
 SimpleWidget.register(JqTreeWidget, "tree");