Add inline disable configuration #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
add/inline-configuration
branch
from
9e60f0b
to
8e350d7
Compare
mbj
commented
Apr 25, 2022
|
|
||
| let(:expected_associations) do | ||
| associations = {} | ||
| associations.compare_by_identity |
There was a problem hiding this comment.
This is forced by parsers comment associator, I'm personally not super in favor to use object memory identity in any kind of API.
I'd prefer parser would use node index to associate, but I cannot change its API.
mbj
commented
Apr 25, 2022
| end | ||
|
|
||
| it 'returns parsed source' do | ||
| expect(subject).to eql(s(:sym, :source)) | ||
| expect(subject.inspect).to eql( |
There was a problem hiding this comment.
Comparing via inspect as Parser::Source::* only does identity on #== and #eql?. And writing peeking assertions is not as exhaustive. Basically an in-memory golden test :P
mbj
force-pushed
the
add/inline-configuration
branch
4 times, most recently
from
fff7aa5
to
9e9f409
Compare
* This allows to place `mutant:disable` comments next to subjects to mark them as disabled. * Inheritance is not supported currently, so a comment on a class will not make this entire class disabled.
mbj
force-pushed
the
add/inline-configuration
branch
3 times, most recently
from
d52ff56
to
38f1e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.