Add block-pass mutations #1047
Merged
Add block-pass mutations #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
commented
Sep 6, 2020
Comment on lines
+187
to
+188
| mutation 'foo(&nil).baz {}' | ||
| mutation 'foo(&self).baz {}' |
There was a problem hiding this comment.
We could optionally skip &nil and &self since I think they are unlikely to yield alives but they are technically valid.
There was a problem hiding this comment.
I think this skip is valid and should be done in a followup. Does not block this PR.
There was a problem hiding this comment.
To elaborate on why: They are "static" expressions. The outcome of &nil and &self is known ahead of time to not be useful.
- Adds `foo(&method(:bar))` -> `foo(&public_method(:bar))` and similar mutations.
dgollahon
force-pushed
the
add-block-pass-mutations
branch
from
f2baa5d
to
a58c6ff
Compare
mbj
approved these changes
Sep 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foo(&method(:bar))->foo(&public_method(:bar))and similar mutations.