Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git in gemspec #1052

Closed
utkarsh2102 opened this issue Sep 9, 2020 · 7 comments · Fixed by #1053
Closed

Drop git in gemspec #1052

utkarsh2102 opened this issue Sep 9, 2020 · 7 comments · Fixed by #1053

Comments

@utkarsh2102
Copy link

Hi @mbj,

Thanks for your lovely work on this! ❤️

However, whilst trying to maintain this in Debian, we found that mutant relies on git to produce a list of files.
Using git in gemspec is a bit troublesome and it's best to not use them!

More about this can be found here: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#packaginggemspecgit

If you agree with this, I'll be very happy to raise a PR for this! 😄

@mbj
Copy link
Owner

mbj commented Sep 9, 2020

@utkarsh2102 I'm happy to change it. No need to PR on yourself. I like the reasoning of the change.

I suspect this also applies to all of mutant dependencies I maintain.

@mbj
Copy link
Owner

mbj commented Sep 9, 2020

@utkarsh2102 curious where is mutant packaged in debian? I never heard about it. Archlinux user here ;)

@utkarsh2102
Copy link
Author

@mbj, hello 👋🏻

No need to PR on yourself. I like the reasoning of the change.

Great, thank you! ❤️
There are some other small things like bumping RuboCop version and using rubocop-packaging that I'd be willing to introduce and so on. In case you want a PR for that, I'd be happy to do that! Let me know!

curious where is mutant packaged in debian? I never heard about it. Archlinux user here ;)

Haha, I use Arch ("BTW"), too 😄
However, I am a Debian core developer and I maintain a bunch of Ruby stuff in Debian. I already maintain anima, concord, unparser, adamantium, morpher, procto, abstract_types, etc there already (so you can also apt install these things ;)) and so when I was packaging mutant for Debian, I faced these problems (using git and so on) and was therefore asking here 😄
Hopefully, in the next weeks, we'll also have mutant-rspec, mutant, and ice_nine as well! 💯

Additionally, I really want to thank you for all your work and willing to help us maintain that! ❤️

mbj added a commit that referenced this issue Sep 10, 2020
@mbj mbj linked a pull request Sep 10, 2020 that will close this issue
@mbj mbj closed this as completed in #1053 Sep 10, 2020
@mbj
Copy link
Owner

mbj commented Sep 10, 2020

@utkarsh2102 For all the gems I'm the "primary" author I've released the following versions that all do not rely on git anymore:

  • concord-0.1.6 (first release in 6 years!)
  • anima-0.3.2
  • unparser-0.4.9
  • mutant-0.9.12

For the other gems I recommend you open the issue at the respective repositories. These gems are typically very small hence still work but their CI setup will have bitrotted. I've to talk to each maintainer on what their preferences are to stetup CI.

@mbj
Copy link
Owner

mbj commented Sep 10, 2020

There are some other small things like bumping RuboCop version and using rubocop-packaging that I'd be willing to introduce and so on. In case you want a PR for that, I'd be happy to do that! Let me know!

you are fine to PR anything you wish. But please be aware that mutant, as its NOT opensource anymore (cannot afford to maintain it under opensource economy) requires you to sign an ICA.

Please contact me in private for details. Find my email in the gemspec.

@mbj
Copy link
Owner

mbj commented Sep 10, 2020

@utkarsh2102 BTW morpher is basically EOL. Mutant::Transform is the next version of this. May be extracted to a separate gem in the future.

@utkarsh2102
Copy link
Author

Hey,

For all the gems I'm the "primary" author I've released the following versions that all do not rely on git anymore:

concord-0.1.6 (first release in 6 years!)
anima-0.3.2
unparser-0.4.9
mutant-0.9.12

Wow, you're the best! 🔥
Thank you! 🤗

For the other gems I recommend you open the issue at the respective repositories. These gems are typically very small hence still work but their CI setup will have bitrotted. I've to talk to each maintainer on what their preferences are to stetup CI.

Ah, sure thing! I'll do this as and when I re-work on those packages! Thanks again! ^.^

Please contact me in private for details. Find my email in the gemspec.

Emailed! \o/

BTW morpher is basically EOL. Mutant::Transform is the next version of this. May be extracted to a separate gem in the future.

Ah, okay! Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants