-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop git
in gemspec
#1052
Comments
@utkarsh2102 I'm happy to change it. No need to PR on yourself. I like the reasoning of the change. I suspect this also applies to all of mutant dependencies I maintain. |
@utkarsh2102 curious where is mutant packaged in debian? I never heard about it. Archlinux user here ;) |
@mbj, hello 👋🏻
Great, thank you! ❤️
Haha, I use Arch ("BTW"), too 😄 Additionally, I really want to thank you for all your work and willing to help us maintain that! ❤️ |
@utkarsh2102 For all the gems I'm the "primary" author I've released the following versions that all do not rely on git anymore:
For the other gems I recommend you open the issue at the respective repositories. These gems are typically very small hence still work but their CI setup will have bitrotted. I've to talk to each maintainer on what their preferences are to stetup CI. |
you are fine to PR anything you wish. But please be aware that mutant, as its NOT opensource anymore (cannot afford to maintain it under opensource economy) requires you to sign an ICA. Please contact me in private for details. Find my email in the gemspec. |
@utkarsh2102 BTW |
Hey,
Wow, you're the best! 🔥
Ah, sure thing! I'll do this as and when I re-work on those packages! Thanks again! ^.^
Emailed! \o/
Ah, okay! Thanks for letting me know! |
Hi @mbj,
Thanks for your lovely work on this! ❤️
However, whilst trying to maintain this in Debian, we found that mutant relies on
git
to produce a list of files.Using
git
in gemspec is a bit troublesome and it's best to not use them!More about this can be found here: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#packaginggemspecgit
If you agree with this, I'll be very happy to raise a PR for this! 😄
The text was updated successfully, but these errors were encountered: