-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Arduino Nano 33 BLE #55
Conversation
...ET_NORDIC/TARGET_NRF5x/TARGET_NRF52/TARGET_MCU_NRF52840/device/TOOLCHAIN_GCC_ARM/NRF52840.ld
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
UploadMethods page updated https://github.com/mbed-ce/mbed-os/wiki/Upload-Methods |
b2185ef
to
68fb224
Compare
Finally got around to hooking up SWD to my Arduino and adding it to my test setup! Test results:
Looks similar to #53 ?
Maybe this is some sort of udev related issue.
|
Made another fix just now that allows the usb-device-serial test to pass 50% of the time. Still seems to randomly fail the other half of the time though. |
…ssing, add option for USB serial by default
…library was not enabled
7a0be3d
to
081cde4
Compare
I'm so close to being able to merge this... finally fixed the linker script issue after hours and hours of work. How I just need to:
Hopefully I can get this done in the next 1-2 weeks. |
Info page created: https://github.com/mbed-ce/mbed-os/wiki/MCU-Info-Page:-Arduino-Nano-33-BLE |
OK, I think my latest commit has resolved the flashing issues in CI. Now, I can connect all three devices I have (LPC1768, Nano 33 BLE, NUCLEO_F429ZI) to the host at the same time and I verified that code gets flashed to the correct ones. @JohnK1987 Once you approve, should be good to merge! |
…e weak implementation can simply be removed, because there's no legitimate case where it is used.
@JohnK1987 OK last one for real, tests showed a bluetooth failure after rebasing due to a weak symbol issue. Should be fixed now. |
Summary of changes
Even though Mbed OS is used to power the Arduino Nano 33 BLE, mainline Mbed doesn't actually support this board out of the box. The Arduino board uses a custom bootloader with a different memory layout, as well as an upload method that does not align with Mbed's tooling. ARM evidently didn't want to deal with this, so Arduino people had to develop their own tooling on top of Mbed, and the ARDUINO_NANO33BLE target was left in an odd half-working state. Until now!
This PR:
Impact of changes
Arduino Nano 33 supported out of the box by Mbed
Migration actions required
Documentation
Still need to do this
Pull request type
Test results
Reviewers
@jay-sridharan
@JohnK1987