-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Blackpill-F411CE #123
add Blackpill-F411CE #123
Conversation
LED correction
Nice work on the info page! Just three comments:
|
Also, the info page should probably mention the If you don't have a UART to USB adapter handy, and you aren't using the USB port in your code, you can also have the board send console output over its own USB port. Just drop the following target overrides into your mbed-app.json: "target.console-uart": false,
"target.console-usb": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Great to see a new board being added
Just a few minor things to go through.
Correcting the wrong name in the Note2 about pyOCD.
Updated notes - an external debugger is required
@multiplemonomials thank you for your feedback,
To be honest I took your https://github.com/mbed-ce/mbed-os/wiki/MCU-Info-Page:-STM32L452xE as an example. So I guess I misunderstood. I make it like:
Ok, I did some reduction just to basic information, on the page.
Yes, I was able to upload MbedCE_app.bin file via STM32CubeProgrammer and STM32 Bootloader (DFU). But I am not sure about this like build-in upload method, you still need to switch the MCU to DFU manually, then there is no point to have it build-in your Build system because it will never work automatically. However I definitely agree with description about how to do that.
This answer will be related to more point across your feedback.
Very good point I forgot on that! I will fill it probably to generic page again like the SWO. BR, Jan |
Code looks good, just waiting on info page updates then I'll approve and merge! |
@multiplemonomials I did some changes, please make review |
OK looks good, go ahead and move those onto the wiki! |
Ok, it is done. |
Summary of changes
This PR will add Blackpill-F411CE as regular target to MbedOS.
Were done:
As a reference I used materials from Zoltan Hudak, who allow me that, thank you.
Impact of changes
I do not see any negative impact or impact to rest of MbedOS.
Migration actions required
N/A
Documentation
The board page is preped on my github repo and can be move after validation and merge of this PR - https://github.com/mbed-ce/mbed-os/wiki/MCU-Info-Page:-STM32F411xE
Pull request type
Test results
I did tests for all enabled upload methods and Greentea test with HSE and also HSI clock source settings and only
mbed-usb-device-basic
failed in both cases. I do not have Nucleo-F411RE for verification, but I mentioned it on the board page and I am able to create an Issue about that (according to as we agree).Greentea result for Blackpill-F411CE
Unfortunately I do not have CI shield so I can not do also this test, but I will try to fix this in the future.
Reviewers
@multiplemonomials @JojoS62