Allow binding fixed precision or scale for decimal type (facebookincu…

…bator#9044) Summary: Fixes facebookincubator#9029 Pull Request resolved: facebookincubator#9044 Reviewed By: Yuhta Differential Revision: D54800731 Pulled By: mbasmanova fbshipit-source-id: 7c15beb9c04c377f543612b1db6f2f0134c419b1
mbasmanova · Mar 12, 2024 · de54d1e · de54d1e
1 parent 86f559c
commit de54d1e
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/velox/expression/SignatureBinder.cpp b/velox/expression/SignatureBinder.cpp
@@ -138,6 +138,9 @@ bool SignatureBinder::tryBind() {
 bool SignatureBinderBase::checkOrSetIntegerParameter(
     const std::string& parameterName,
     int value) {
+  if (isPositiveInteger(parameterName)) {
+    return atoi(parameterName.c_str()) == value;
+  }
   if (!variables().count(parameterName)) {
     // Return false if the parameter is not found in the signature.
     return false;

diff --git a/velox/expression/tests/SignatureBinderTest.cpp b/velox/expression/tests/SignatureBinderTest.cpp
@@ -240,6 +240,31 @@ TEST(SignatureBinderTest, decimals) {
           "Type variables cannot have constraints");
     }
   }
+  // Scalar function signature with fixed scale.
+  {
+    {
+      auto signature = exec::FunctionSignatureBuilder()
+                           .integerVariable("precision")
+                           .returnType("boolean")
+                           .argumentType("DECIMAL(precision, 6)")
+                           .build();
+      testSignatureBinder(signature, {DECIMAL(11, 6)}, BOOLEAN());
+      assertCannotResolve(signature, {DECIMAL(11, 8)});
+    }
+    {
+      auto signature = exec::FunctionSignatureBuilder()
+                           .integerVariable("precision")
+                           .integerVariable("scale")
+                           .returnType("DECIMAL(precision, scale)")
+                           .argumentType("DECIMAL(precision, 6)")
+                           .argumentType("DECIMAL(18, scale)")
+                           .build();
+      testSignatureBinder(
+          signature, {DECIMAL(11, 6), DECIMAL(18, 4)}, DECIMAL(11, 4));
+      assertCannotResolve(signature, {DECIMAL(11, 6), DECIMAL(20, 4)});
+      assertCannotResolve(signature, {DECIMAL(11, 8), DECIMAL(18, 4)});
+    }
+  }
 }
 
 TEST(SignatureBinderTest, computation) {